Commit Graph

261 Commits

Author SHA1 Message Date
Alexander Krotov
e5697f0c2c Remove ByteTagList::IsDirty{Start,End}
These functions are only used once and do not save time.  Both functions
iterate over the whole list just to prevent iterating over the whole list
if they return false. As traversing the list is required in any case,
these functions can be removed.
2015-07-26 19:44:06 +03:00
Alexander Krotov
ded303057a When data is written with WriteU64, it should be tested with ReadU64,
not ReadLsbtohU64.
2015-08-02 20:44:01 +03:00
Alexander Krotov
b62cf68711 Make Buffer::CreateFullCopy private 2015-08-02 19:26:37 +03:00
Alexander Krotov
6250c61bcf Optimize Buffer::Iterator::CheckNoZero 2015-07-26 19:44:29 +03:00
Mathieu Lacage
fd74ac7616 remove un-needed return value 2015-08-05 15:20:10 -04:00
Mathieu Lacage
3ae948f663 ByteTagList::AddAtEnd/AddAtStart must be called unconditionally to ensure that newly-added bytes are not tagged when 1. Packet::AddByteTag, 2. Packet::RemoveHeader, 3. Packet.AddHEader 2015-08-05 15:11:19 -04:00
Alexander Krotov
b0577a2eac Add "unfixable" ByteTagList test case
This test case creates empty packet, removes last 50 bytes and
adds them back.

As packet is empty initially, no bytes are marked dirty.  Therefore,
Buffer::AddAtEnd returns false, indicating that added bytes were not used
before.  However, it does not know if they were tagged with byte tags.

This bug is not so easy to fix as Buffer does not have enough information
to return true in Buffer::AddAtEnd when it should.
2015-07-26 19:44:31 +03:00
Alexander Krotov
8f515dcc03 Add failing PaddingAtEnd test case 2015-07-26 19:44:30 +03:00
Alexander Krotov
def03785bf Add ByteTagList tests, 3 out of 4 failing 2015-07-26 19:44:29 +03:00
Peter D. Barnes, Jr.
69dd251a0f [Doxygen] Better documentation for NS_DEPRECATED 2015-07-10 18:13:14 -07:00
Matthieu Coudron
2f63edb779 Add SinkWithHeader to PcapHelper 2015-07-22 01:13:06 +02:00
Sébastien Deronne
0d5fc14442 add support for HT MCS and A-MPDU in radiotap headers 2015-07-08 23:44:17 +02:00
Tommaso Pecorella
d74e9fdf30 Enh. 2130 - Allow SimpleChannel to simulate hidden terminals. 2015-06-11 19:07:25 +02:00
Tommaso Pecorella
cbe83c6f5a Bug 2138 - SimpleNetDevice could send overlapped packets. 2015-06-11 11:40:53 +02:00
Tom Henderson
8df0d04bbb add missing copyrights 2015-06-10 07:52:23 -07:00
Peter D. Barnes, Jr.
d67ced0392 Fix parents, group names, and missing constructors in GetTypeId definitions. 2015-06-09 12:59:59 -07:00
Peter D. Barnes, Jr.
a2e0ed145a Missing mode lines. 2015-06-08 16:37:40 -07:00
Tom Henderson
ab88e121ca fix attribute accessor for DropTailQueue Mode attribute (reported by Chip Webb) 2015-06-08 13:46:18 -07:00
Peter D. Barnes, Jr.
5545a7f224 Remove extraneous ' ' around :: 2015-02-04 13:40:57 -08:00
Peter D. Barnes, Jr.
9f88bd50f0 On mismatch PcapFile::Diff reports packet number. 2015-02-04 12:35:17 -08:00
Tom Henderson
92d33e8c9e rescan bindings 2015-05-05 21:29:58 -07:00
Tom Henderson
d8494dfb97 add missing namespace qualifier 2015-03-27 07:12:37 -07:00
Mohit Goyal
811962d3e0 SetGroupName for network module 2015-03-27 07:03:58 -07:00
Vedran Miletić
3edd12c191 Fix building with GCC 5 and subsequently clean up sgi-hashmap.h 2015-03-05 15:50:18 +01:00
Natale Patriciello
b27422fb2f Bug 2070 - Wrong report of Packets and Bytes stored in CoDeL 2015-03-01 12:08:36 +01:00
Tommaso Pecorella
0630f6dee9 Bug 1974 - CalculateTxTime should return a Time, not a double 2015-02-28 18:20:46 +01:00
Tom Henderson
ffa4909b25 bug 2044: Buffer::Iterator::ReadNtohU16() and ReadNtohU32() not implemented correctly 2015-01-30 16:27:50 -08:00
Tom Henderson
2be7d2e686 Doxygen corrections for class Buffer 2015-01-30 16:06:55 -08:00
Peter D. Barnes, Jr.
40eb448c95 [Doxygen] Remove extraneous docs for derivatives of AttributeValue. 2015-01-16 12:12:46 -08:00
Peter D. Barnes, Jr.
8de4b6ed1e [Doxygen] Clean up references to non-POD TracedValueCallbacks 2014-12-12 14:48:13 -08:00
Tom Henderson
e1108928f1 rescan bindings 2014-12-19 16:22:49 -08:00
Peter D. Barnes, Jr.
692bf472e6 TracedCallback function signatures, the rest. 2014-12-04 10:02:01 -08:00
Peter D. Barnes, Jr.
4cb9c7b916 TracedCallback function signatures, the simple ones.
These are TracedCallback function signatures for traces sources
using a single argument.
2014-10-03 02:24:42 -07:00
Natale Patriciello
37ed3b545b ToString method to Packet 2014-11-14 15:27:37 -08:00
Peter D. Barnes, Jr.
ee641c723b [Doxygen] Remove inappropriate uses of @internal 2014-11-03 12:33:13 -08:00
Peter D. Barnes, Jr.
cccfc167dd [Doxygen] Attribute implementations. 2014-10-21 16:14:35 -07:00
Tom Henderson
31d2a3aad7 rescan bindings 2014-10-14 11:36:00 -07:00
Tom Henderson
5d2310d3d8 removed unused includes 2014-10-14 10:02:08 -07:00
Tom Henderson
37bab66bfe remove deprecated Packet::PeekData() 2014-10-14 09:36:10 -07:00
Tom Henderson
c41ba4e79a rescan bindings 2014-10-13 21:25:21 -07:00
Tommaso Pecorella
fcda743c44 [Doxygen] network module 2014-10-07 21:37:00 +02:00
Peter D. Barnes, Jr.
b2dc58dcb9 Use StringValue instead of PointerValue (CreateObject... in AddAttribute calls 2014-10-06 17:22:59 -07:00
Peter D. Barnes, Jr.
c10b5622a0 [Doxygen] Minor fix-ups 2014-10-08 11:59:31 -07:00
Tom Henderson
d471d382ac rescan bindings 2014-10-07 12:19:52 -07:00
Tommaso Pecorella
899626019f [Doxygen] minor fixes 2014-10-03 23:51:58 +02:00
Peter D. Barnes, Jr.
cc56e83767 TracedValue callback function signatures. 2014-10-02 21:17:48 -07:00
Peter D. Barnes, Jr.
bfdb6ef10a [Bug 1551] Redux: NS_LOG_COMPONENT_DEFINE inside or outside of ns3 namespace? 2014-09-26 15:51:00 -07:00
Peter D. Barnes, Jr.
3611bd11a5 [Bug 1551] NS_LOG_COMPONENT_DEFINE inside or outside of ns3 namespace? 2014-09-26 12:44:13 -07:00
Tommaso Pecorella
234e84dc35 Bug 1991 - PcapFileWrapper::CaptureSize attribute (snaplen) has no effect. 2014-09-19 21:23:55 +02:00
Tom Henderson
c994aa10d8 rescan remaining bindings 2014-09-15 20:51:08 -07:00