F5/unison
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

remove un-needed return value

Browse Source
This commit is contained in:
Mathieu Lacage
2015-08-05 15:20:10 -04:00
parent 3ae948f663
commit fd74ac7616
2 changed files with 4 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/network/model/buffer.cc
View File

@@ -305,11 +305,10 @@ Buffer::GetInternalEnd (void) const
return m_end - (m_zeroAreaEnd - m_zeroAreaStart);
}
bool
void
Buffer::AddAtStart (uint32_t start)
{
NS_LOG_FUNCTION (this << start);
bool dirty;
NS_ASSERT (CheckInternalState ());
bool isDirty = m_data->m_count > 1 && m_start > m_data->m_dirtyStart;
if (m_start >= start && !isDirty)
@@ -321,7 +320,6 @@ Buffer::AddAtStart (uint32_t start)
*/
NS_ASSERT (m_data->m_count == 1 || m_start == m_data->m_dirtyStart);
m_start -= start;
dirty = m_start > m_data->m_dirtyStart;
// update dirty area
m_data->m_dirtyStart = m_start;
}
@@ -347,20 +345,15 @@ Buffer::AddAtStart (uint32_t start)
// update dirty area
m_data->m_dirtyStart = m_start;
m_data->m_dirtyEnd = m_end;
dirty = true;
}
m_maxZeroAreaStart = std::max (m_maxZeroAreaStart, m_zeroAreaStart);
LOG_INTERNAL_STATE ("add start=" << start << ", ");
NS_ASSERT (CheckInternalState ());
return dirty;
}
bool
void
Buffer::AddAtEnd (uint32_t end)
{
NS_LOG_FUNCTION (this << end);
bool dirty;
NS_ASSERT (CheckInternalState ());
bool isDirty = m_data->m_count > 1 && m_end < m_data->m_dirtyEnd;
if (GetInternalEnd () + end <= m_data->m_size && !isDirty)
@@ -374,9 +367,6 @@ Buffer::AddAtEnd (uint32_t end)
m_end += end;
// update dirty area.
m_data->m_dirtyEnd = m_end;
dirty = m_end < m_data->m_dirtyEnd;
}
else
{
@@ -400,15 +390,10 @@ Buffer::AddAtEnd (uint32_t end)
// update dirty area
m_data->m_dirtyStart = m_start;
m_data->m_dirtyEnd = m_end;
dirty = true;
}
m_maxZeroAreaStart = std::max (m_maxZeroAreaStart, m_zeroAreaStart);
LOG_INTERNAL_STATE ("add end=" << end << ", ");
NS_ASSERT (CheckInternalState ());
return dirty;
}
void

6
src/network/model/buffer.h
View File

@@ -496,7 +496,6 @@ private:
/**
* \param start size to reserve
* \returns true if the buffer needed resizing, false otherwise.
*
* Add bytes at the start of the Buffer. The
* content of these bytes is undefined but debugging
@@ -504,10 +503,9 @@ private:
* Any call to this method invalidates any Iterator
* pointing to this Buffer.
*/
bool AddAtStart (uint32_t start);
void AddAtStart (uint32_t start);
/**
* \param end size to reserve
* \returns true if the buffer needed resizing, false otherwise.
*
* Add bytes at the end of the Buffer. The
* content of these bytes is undefined but debugging
@@ -515,7 +513,7 @@ private:
* Any call to this method invalidates any Iterator
* pointing to this Buffer.
*/
bool AddAtEnd (uint32_t end);
void AddAtEnd (uint32_t end);
/**
* \param o the buffer to append to the end of this buffer.