F5/unison
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

TCP's attribute variables are initialized in constructor (mutes valgrind)

Browse Source
This commit is contained in:
Adrian S Tam
2011-12-01 21:41:16 -05:00
parent af8ae01917
commit d349afb5e4
3 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/internet/model/tcp-newreno.cc
View File

@@ -55,7 +55,10 @@ TcpNewReno::GetTypeId (void)
return tid;
}
TcpNewReno::TcpNewReno (void) : m_inFastRec (false)
TcpNewReno::TcpNewReno (void)
: m_retxThresh (3), // mute valgrind, actual value set by the attribute system
m_inFastRec (false),
m_limitedTx (false) // mute valgrind, actual value set by the attribute system
{
NS_LOG_FUNCTION (this);
}
@@ -65,7 +68,9 @@ TcpNewReno::TcpNewReno (const TcpNewReno& sock)
m_cWnd (sock.m_cWnd),
m_ssThresh (sock.m_ssThresh),
m_initialCWnd (sock.m_initialCWnd),
m_inFastRec (false)
m_retxThresh (sock.m_retxThresh),
m_inFastRec (false),
m_limitedTx (sock.m_limitedTx)
{
NS_LOG_FUNCTION (this);
NS_LOG_LOGIC ("Invoked the copy constructor");

3
src/internet/model/tcp-reno.cc
View File

@@ -51,7 +51,7 @@ TcpReno::GetTypeId (void)
return tid;
}
TcpReno::TcpReno (void) : m_inFastRec (false)
TcpReno::TcpReno (void) : m_retxThresh (3), m_inFastRec (false)
{
NS_LOG_FUNCTION (this);
}
@@ -61,6 +61,7 @@ TcpReno::TcpReno (const TcpReno& sock)
m_cWnd (sock.m_cWnd),
m_ssThresh (sock.m_ssThresh),
m_initialCWnd (sock.m_initialCWnd),
m_retxThresh (sock.m_retxThresh),
m_inFastRec (false)
{
NS_LOG_FUNCTION (this);

5
src/internet/model/tcp-tahoe.cc
View File

@@ -51,7 +51,7 @@ TcpTahoe::GetTypeId (void)
return tid;
}
TcpTahoe::TcpTahoe (void) : m_initialCWnd (0)
TcpTahoe::TcpTahoe (void) : m_initialCWnd (1), m_retxThresh (3)
{
NS_LOG_FUNCTION (this);
}
@@ -60,7 +60,8 @@ TcpTahoe::TcpTahoe (const TcpTahoe& sock)
: TcpSocketBase (sock),
m_cWnd (sock.m_cWnd),
m_ssThresh (sock.m_ssThresh),
m_initialCWnd (sock.m_initialCWnd)
m_initialCWnd (sock.m_initialCWnd),
m_retxThresh (sock.m_retxThresh)
{
NS_LOG_FUNCTION (this);
NS_LOG_LOGIC ("Invoked the copy constructor");