F5/unison
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

wifi: Workaround to avoid a crash when expecting a TB PPDU and receiving a pre-11ax PPDU

Browse Source 
A real fix requires to review the PHY design so that a PHY entity can
somehow control the reception of PPDUs of previous modulation classes.
This commit is contained in:
Stefano Avallone
2022-03-28 12:36:04 +02:00
parent 77a70fb5c7
commit c01e14c43f
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/wifi/model/he/he-frame-exchange-manager.cc
View File

@@ -1473,7 +1473,13 @@ HeFrameExchangeManager::ReceiveMpdu (Ptr<WifiMacQueueItem> mpdu, RxSignalInfo rx
mpdu->GetPacket ()->PeekPacketTag (tag);
ReceivedNormalAck (*it->second->begin (), m_txParams.m_txVector, txVector, rxSignalInfo, tag.Get ());
}
else if (hdr.IsBlockAck () && m_txTimer.IsRunning ()
// TODO the PHY should not pass us a non-TB PPDU if we are waiting for a
// TB PPDU. However, processing the PHY header is done by the PHY entity
// corresponding to the modulation class of the PPDU being received, hence
// it is not possible to check if a valid TRIGVECTOR is stored when receiving
// PPDUs of older modulation classes. Therefore, we check here that we are
// actually receiving a TB PPDU.
else if (hdr.IsBlockAck () && txVector.IsUlMu () && m_txTimer.IsRunning ()
&& m_txTimer.GetReason () == WifiTxTimer::WAIT_BLOCK_ACKS_IN_TB_PPDU)
{
Mac48Address sender = hdr.GetAddr2 ();