F5/unison
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

BlockAckCache: fix wrong formula for update of winEnd index (thanks Ghada Badawy).

Browse Source
This commit is contained in:
Mirko Banchi
2012-07-23 18:49:59 +02:00
parent 6e1c343e60
commit a20b7e8d49
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/wifi/model/block-ack-cache.cc
View File

@@ -31,7 +31,7 @@ BlockAckCache::Init (uint16_t winStart, uint16_t winSize)
{
m_winStart = winStart;
m_winSize = winSize <= 64 ? winSize : 64;
m_winEnd = ((m_winStart + m_winSize) % 4096) - 1;
m_winEnd = (m_winStart + m_winSize - 1) % 4096;
memset (m_bitmap, 0, sizeof (m_bitmap));
}
@@ -67,7 +67,7 @@ BlockAckCache::UpdateWithBlockAckReq (uint16_t startingSeq)
if (startingSeq != m_winStart)
{
m_winStart = startingSeq;
uint16_t newWinEnd = ((m_winStart + m_winSize) % 4096) - 1;
uint16_t newWinEnd = (m_winStart + m_winSize - 1) % 4096;
ResetPortionOfBitmap ((m_winEnd + 1) % 4096, newWinEnd);
m_winEnd = newWinEnd;
@@ -77,7 +77,7 @@ BlockAckCache::UpdateWithBlockAckReq (uint16_t startingSeq)
else
{
m_winStart = startingSeq;
m_winEnd = ((m_winStart + m_winSize) % 4096) - 1;
m_winEnd = (m_winStart + m_winSize - 1) % 4096;
ResetPortionOfBitmap (m_winStart, m_winEnd);
WINSIZE_ASSERT;
@@ -112,7 +112,7 @@ BlockAckCache::FillBlockAckBitmap (CtrlBAckResponseHeader *blockAckHeader)
else if (blockAckHeader->IsCompressed ())
{
uint32_t i = blockAckHeader->GetStartingSequence ();
uint32_t end = ((i + m_winSize) % 4096) - 1;
uint32_t end = (i + m_winSize - 1) % 4096;
for (; i != end; i = (i + 1) % 4096)
{
if (m_bitmap[i] == 1)