Commit Graph

12864 Commits

Author SHA1 Message Date
Tom Henderson
dbaa3d3a86 wifi: Rescan python bindings 2021-11-09 11:51:35 -08:00
Sharan Naribole
6394a30aa9 wifi: (fixes #459) Fix HeCapabilities IEEE 802.11ax-compliance 2021-11-08 09:21:46 +00:00
Eduardo Almeida
5dc117216a Fix doxygen warning 2021-11-04 14:19:29 -07:00
Eduardo Almeida
a2efceffb2 Simplify trivial bool statements 2021-11-04 14:19:29 -07:00
Greg Steinbrecher
161c4fa2ce internet: read correct bits when deserializing IPv6 flow label
On line 153, `m_flowLabel` is OR-ed into the LSBs of `vTcFl`, which is then written with `WriteHtonU32` into the buffer. On line 169, `vTcFl` is read out using `ReadNtohU32`, so the byte order should be the same as it was on line 153. However, currently `m_flowLabel` is being assigned the value of `vTcFl` masked by `0xfff00000`.

This commit changes line 177 to read the correct set of 20 bits to recover the original flow label.

One question: Right now, `SetFlowLabel` (and the other setters) don't check that the value is in range, and Serialize doesn't mask them. Should this be fixed? Right now, a large flow label would clobber the traffic class and version fields.
2021-11-04 06:52:21 -07:00
Stefano Avallone
d10e28b16f wifi: Be more robust against invalidation of iterators 2021-11-03 09:57:55 +01:00
Stefano Avallone
cdbd6a286f wifi: Fixup commit aba62274 2021-11-03 09:42:47 +01:00
Eduardo Almeida
2421656133 fd-net-device (Fix 539218e5): Add missing include removed by accident 2021-10-30 12:56:28 +01:00
Davide Magrin
0b3c2b3fd2 wifi: Initialize WifiUlMuMultiStaBa as MULTI_STA
This commit changes the constructor of WifiUlMuMultiStaBa to directly
initialize the baType to BlockAckType::MULTI_STA. This prevents the
creation of an element in bitmapLen (which happens when the BlockAckType
is set to BASIC, the default baType).
2021-10-29 19:15:09 +02:00
Tommaso Pecorella
4895deeefd internet: further fixes to Doxygen description of callback signatures 2021-10-28 01:34:28 +02:00
Gard Spreemann
f9ac0f0382 Correct typos in Doxygen description of callback signatures 2021-10-27 23:13:32 +00:00
Stefano Avallone
70adab8d72 wifi: (fixes #475) Ask the correct EDCAF to prepare a BAR following a DL MU PPDU 2021-10-26 19:06:53 +02:00
Eduardo Almeida
539218e593 fd-net-device: Remove unnecessary includes 2021-10-25 11:01:20 +00:00
Tommaso Pecorella
998166a95d fd-net-device: fix doxygen warnings 2021-10-24 17:14:57 +02:00
Tommaso Pecorella
d1169d40ad core: fix some doxygen warnings 2021-10-24 17:14:32 +02:00
Tom Henderson
e844dfd1d7 wifi: (fixes #473) Discard preamble state for truncated TX or device in OFF 2021-10-22 14:34:25 -07:00
Ameya Deshpande
97d5f8d069 nix-vector-routing: Fix documentation
- The examples section formatting is fixed
- NMS image is shown properly
- Correct backward header compatibility note with
  header deprecation note.

Signed-off-by: Ameya Deshpande <ameyanrd@outlook.com>
2021-10-22 17:07:33 +00:00
Tom Henderson
1516b8891d internet: Update Python bindings 2021-10-21 16:18:13 -07:00
Tommaso Pecorella
22ca1d332d internet: (fixes #431) ICMPv6 error messages carry packet metadata 2021-10-20 22:21:31 +00:00
Stefano Avallone
34663dbfd3 wifi: Rescan python bindings 2021-10-20 15:38:12 +02:00
Stefano Avallone
aba6227449 wifi: Iterate over the in-flight MPDUs in reverse order
A newly added MPDU is likely to have a Sequence Number higher than the
previous ones, hence it likely has to be inserted at the end of the list.
2021-10-20 12:13:50 +02:00
Stefano Avallone
cf8ef91a29 wifi: Do not check lifetime expiration when dequeuing frames
Frames are dequeued when they have been acknowledged, dropped
or are going to be replaced by other frames. In all such cases,
it is not needed to check for lifetime expiration. This check instead
causes troubles when the lifetime of a frame expires while receiving
the acknowledgment (a BAR may be scheduled unnecessarily).
2021-10-20 12:13:50 +02:00
Stefano Avallone
3ad1dde7a1 wifi: Make WifiMacQueue::Insert private
Also, reduce the usage of WifiMacQueue::PushFront. The goal is to
only allow enqueuing packets at the end of the wifi MAC queue, in
view of the introduction of a wifi MAC queue scheduler.
2021-10-19 20:10:25 +02:00
Stefano Avallone
dae6bbca5b wifi: Iterators to queued items are not exposed by WifiMacQueueItem 2021-10-19 20:10:25 +02:00
Stefano Avallone
b8bc106706 wifi: Remove unused global empty wifi MAC queue 2021-10-19 20:10:25 +02:00
Stefano Avallone
882a746500 wifi: Replace iterators with pointers to queued items in public APIs 2021-10-19 20:10:22 +02:00
Stefano Avallone
cf2ccdc041 wifi: Add WifiMacQueue methods to manipulate queued items
Also, remove unused Remove overload.
2021-10-19 20:07:27 +02:00
Stefano Avallone
c35945ebf2 wifi: Install (Qos)Txop objects appropriately 2021-10-13 17:40:31 +02:00
Stefano Avallone
8e1c5525ab wifi: RegularWifiMac::QosSupported attribute must be properly set
We don't override it later (when setting the standard) anymore
2021-10-13 16:07:56 +02:00
Ameya Deshpande
f25866e922 nix-vector-routing: (fixes #466) Handle loopback IPv4/6 addresses
- Add the condition for handling loopback addresses in `RouteOutput ()`.
- Add about this change in "Scope and Limitations" of Nix documentation.

Signed-off-by: Ameya Deshpande <ameyanrd@outlook.com>
2021-10-12 15:13:13 +00:00
Stefano Avallone
dcf022ad8b wifi: (fixes #468) Compute correct size of MU-BAR Trigger Frames 2021-10-12 09:56:50 +02:00
Stefano Avallone
dba8375e18 wifi: (fixes #467) AP only records association failed when AssocResp is discarded 2021-10-11 17:44:53 +02:00
Ameya Deshpande
1f894ae7eb nix-vector-routing: Remove the unused BuildNixVectorLocal () function
This commit removes the dead function `BuildNixVectorLocal ()`.
This issue is discussed in #466.

Signed-off-by: Ameya Deshpande <ameyanrd@outlook.com>
2021-10-11 09:32:02 +00:00
Tommaso Pecorella
b7ddd9d3f5 internet: Align RIPng and RIP implementations 2021-10-10 00:54:21 +02:00
Tommaso Pecorella
db1fa07947 internet: Fix RIPng address selection for intermediate nodes 2021-10-10 00:09:49 +02:00
Tommaso Pecorella
ed8d74879a internet: Fix src address selection for localhost 2021-10-10 00:09:00 +02:00
Tommaso Pecorella
24f73cc470 internet: fix icmpv6 test 2021-10-06 23:04:57 +00:00
Stefano Avallone
96fdc81c68 wifi: Mark an MPDU as acknowledged before removing it from the in-flight queue
This avoids a crash in the event that an MPDU sent in an S-MPDU under
a Block Ack agreement is acknowledged after its lifetime expired.
2021-10-06 17:16:22 +02:00
Sébastien Deronne
a34c01091c wifi: Fix includes in YansErrorRateModel 2021-10-04 21:43:02 +02:00
Aditya Chirania
b5dee14b24 tcp: Update ns3-tcp-loss test artifacts for previous commit 2021-09-29 14:09:01 -07:00
Gauri Prasad
235732f6af tcp: (fixes #410) Fix TCP Westwood bandwidth estimation bug 2021-09-29 14:06:47 -07:00
Bhaskar Kataria
9844819d88 traffic-control: (from !706) Fix FqPIE qdisc not using attributes 2021-09-29 13:58:29 -07:00
Tom Henderson
28886a3a25 traffic-control: (fixes #258) Avoid overflow, divide-by-zero in TbfQueueDisc
Thanks to Tianfan Zhang for finding the bug and starting a patch to fix.
2021-09-27 14:35:16 -07:00
Tom Henderson
4e9afa965d bindings: Rescan all APIs 2021-09-27 11:18:37 -07:00
Sébastien Deronne
017a08c44f wifi: Cleanup some remaining references to MacLow 2021-09-26 21:42:24 +00:00
Gabriel Ferreira
5c13e6014e wifi: remove unnecessary GetSifs calls 2021-09-26 20:46:44 +00:00
Sébastien Deronne
946472f0ca wifi: Add support for 4096-QAM in YansErrorRateModel 2021-09-26 17:26:09 +00:00
Sébastien Deronne
924860e9e3 wifi: Some more PHY rework to support amendments beyond 802.11ax 2021-09-26 17:26:09 +00:00
Stefano Avallone
62542e5fb9 wifi: WifiMacQueueItem does not keep a pointer to the queue it is stored into
Instead, it keeps the AC index associated with the queue it is stored into
2021-09-26 17:06:27 +00:00
Stefano Avallone
97c888cd55 wifi: Add a RegularWifiMac method to return a specified MAC queue 2021-09-26 17:06:27 +00:00