This is based on the following email exchange with the author of this
file:
From: Konstantin Yagola info@spicebrains.com
Subject: Re: License for Simple Javascript Drop-Down Menu v2.0
Date: November 6, 2021 at 12:50 PM
To: Barnes, Peter D. barnes26@llnl.gov
Hi Peter,
> Please let me know if this is acceptable.
acceptable.
-K.
On 05.11.2021 23:38, Barnes, Peter D. wrote:
> Hello Konstantin,
>
> I apologize but I have led you astray. Apparently the license I suggested
> is not appropriate for source code. An appropriate software license would
> be the “modified BSD (3 clause) license”, which is here:
> https://directory.fsf.org/wiki/License:BSD-3-Clause
>
> Please let me know if this is acceptable.
>
> Thanks again for your help in resolving this.
> Peter
>
> On Oct 13, 2021, at 9:15 AM, Konstantin Yagola <info@spicebrains.com> wrote:
>>
>> Hello Barnes,
>>
>> You are right, I'm not familiar with licensing )
>> This is old not complicated script, so you may maintain it based on fair use.
>> If you think "CC BY-SA 4.0” suits best - then ok.
>>
>> -Kind regards,
>> -K Y.
>>
>> On 12.10.2021 1:55, Barnes, Peter D. wrote:
>>> Hello Folks,
>>>
>>> I am one of the maintainers for the ns-3 Simulator project:
>>> https://www.nsnam.org
>>>
>>> It has come to my attention that we are using your Simple Javascript
>>> Drop-Down Menu v2.0, but the use license is not clear.
>>>
>>> Our use is here:
>>> https://gitlab.com/nsnam/ns-3-dev/-/blob/master/doc/ns3_html_theme/static/drop-down-menu.js
>>>
>>> As requested on your page, we have given attribution to your page.
>>> However, since the javascript is copyrighted, there should be a
>>> statement of licensing terms, or reference to a standard license.
>>>
>>> Could you please advise us of the license terms? If you are not familiar
>>> with licensing, perhaps you would consider one of the well-known Creative
>>> Commons licenses? They have a short form which can help you pick one
>>> to meet your needs:
>>> https://chooser-beta.creativecommons.org
>>>
>>> Given your encouraging statement
>>>
>>>> That's it! All you have to do now is add some hover styles and make it
>>>> your own. Enjoy!
>>>> If you want to use this script on your page, please place link to
>>>> http://javascript-array.com at one of your pages.
>>>
>>> might I suggest "CC BY-SA 4.0”.
>>>
>>> Please let me know if that is acceptable, or if you choose another license,
>>> and I will update our file to reflect that.
>>>
>>> Thanks,
>>> Peter
On line 153, `m_flowLabel` is OR-ed into the LSBs of `vTcFl`, which is then written with `WriteHtonU32` into the buffer. On line 169, `vTcFl` is read out using `ReadNtohU32`, so the byte order should be the same as it was on line 153. However, currently `m_flowLabel` is being assigned the value of `vTcFl` masked by `0xfff00000`.
This commit changes line 177 to read the correct set of 20 bits to recover the original flow label.
One question: Right now, `SetFlowLabel` (and the other setters) don't check that the value is in range, and Serialize doesn't mask them. Should this be fixed? Right now, a large flow label would clobber the traffic class and version fields.
This commit changes the constructor of WifiUlMuMultiStaBa to directly
initialize the baType to BlockAckType::MULTI_STA. This prevents the
creation of an element in bitmapLen (which happens when the BlockAckType
is set to BASIC, the default baType).
Frames are dequeued when they have been acknowledged, dropped
or are going to be replaced by other frames. In all such cases,
it is not needed to check for lifetime expiration. This check instead
causes troubles when the lifetime of a frame expires while receiving
the acknowledgment (a BAR may be scheduled unnecessarily).
Also, reduce the usage of WifiMacQueue::PushFront. The goal is to
only allow enqueuing packets at the end of the wifi MAC queue, in
view of the introduction of a wifi MAC queue scheduler.
