spectrum: Remove obsolete code line
spectrum: Fix MatrixBasedChannelModel Doxygen
spectrum: Fix SpectrumSignalParameters Doxygen
spectrum: Fix ThreeGppSpectrumPropagationLossModel Doxygen
spectrum: Rename get horizontal number of elements in the port
spectrum: Rename GetElem->Elem
spectrum: More consistent usage of auto in ThreeGppChannelExample
spectrum: ThreeGppSpectrum to use HermitianTranspose that is a member of MatrixArray
spectrum: GetPolAngle->GetPolSlant MR2
spectrum: Rename IsPolDual -> IsDualPol, and IsPolarized->IsDualPolarized
spectrum: Replace GetNumPolarization with simple code
spectrum: Remove unnecessary copy of rxParams
spectrum: Rename sAntElmnts/uAntElmnts to more intuitive sPortElems/uPortElems
spectrum: Improve comment in CalcBeamformingGain, add line breaks
spectrum: Fix comment in spectrum-signal-parameters
spectrum: Simplify the code for spectrum channel matrix calculation
fix spell check type vice-versa
Add <map> include
spectrum: Update variables to use size_t instead of uint16_t
spectrum: Refactor the code related to polarization and move it to antenna
spectrum: Documents the full MIMO extensions
spectrum: fix doxygen y comments
spectrum: fix documentation
fix spectrum doc
spectrum: Minor documentation cleaning
spectrum: Simplify the interface
Minor fixes in spectrum 3gpp
spectrum: Add a reference and a comment in the code for the multi-port
model and 3GPP sub-array partition model for the TXRU virtualization
Includes:
- refactor build_lib and build_lib_example macros
- unify src and contrib macros
- replace macro with function not to leak definitions
- parse list of arguments
- different cmake-format file for modules to list one item per line
Co-authored-by: Sandra Lagen <sandra.lagen@cttc.es>
This commit also fixes an issue that was discovered during this implementation,
and that is that the stream was never assigned for the uniform random variable used for
the term D and alpha generation.
-Store term D and alpha into the channel params structure.
-Make sure to use correct angles and zenit of departure and arrival:
Save the direction of the generation of the channel params and channel matrix,
in order to know when regenerating channel matrix if the saved angles aoa, aod,
zoa and zod are of of s-to-u or u-to-s, so to properly use them.
- Simplify the type of the key of channel matrix map
- Remove unecessary if statements and abort replace by assert
- Add a more detailed description of the ThreeGppSpectrumPropagationLossModel changes
This possibility is needed for the types of spectrum propagation models that need to have a pointer
to the TX and RX antenna arrays to perform calculations, such as e.g.,
ThreeGppSpectrumPropagationLossModel, which currently has hard limitation of having a maximum of 1
antenna array instance per device. ThreeGppSpectrumPropagationLossModel now inherits a new class
PhasedArraySpectrumPropagationLossModel. Its DoCalcRxPowerSpectralDensity function has now two
additional parameters: TX and RX antenna arrays. Also, AddDevice function is removed from
ThreeGppSpectrumPropagationLossModel, because it is not anymore needed to specify for each
device its TX/RX antenna, since these are now passed as parameters. Hence, to use
ThreeGppSpectrumPropagationLossModel, when implementing Spectrum PHY features,
modules should implement the function of SpectrumPhy GetAntenna to return the instance of
PhasedArrayModel of that SpectrumPhy. These instances will be passed by MultiModelSpectrumChannel
(one of the core classes in the spectrum module) to propagation classes, children of
PhasedArraySpectrumPropagationLossModel, when it is necessary to DoCalcRxPowerSpectralDensity to
callculate the propagation loss.
Additionally: Fixed pair key generation for 3gpp channel model: Previous implementation was
using a cantor function of two integer of 32 bits and as a results was giving a unique
representatio of 32 bits. This is wrong, because such function needed even more than 64
bits to represent that value. Even if in ns-3 simulation we are not going to have such large
node numbers, we should fix this. Instead of just changing 64 bits from cantor function, I propose to
replace the cantor function with just simple concatenation of two 32 bits.
I also propose moving min and max inside of the function, to prevent some eventual future errors
in using GetKey, because with the previous implementation there was assumption that who calls GetKey
will previously sort its parameters, and first provide the min value, and then the max value,
and this was not even documented.
- Introduce PhasedArrayModel
- Use the new PhasedArrayModel framework across modules (e.g., 3gpp channel model)
- Improve Angles class. Furthermore, Angles has been translated from elevation to inclination and from degrees to radians
- Update antenna module doc
- Fix random angle generation for the 3gpp channel model. Specifically, cluster and sub-cluster angles might be generated with inclination angles outside the inclination range [0, pi], and have now been fixed.
