From f3c21636585c8c7206932ce3f326bf8dff572c0c Mon Sep 17 00:00:00 2001
From: Tolik Zinovyev <tolik@bu.edu>
Date: Tue, 15 Mar 2022 09:35:01 +0000
Subject: [PATCH] wifi: Return a const reference from WifiMode::GetUniqueName()

---
 src/wifi/model/wifi-mode.cc      | 2 +-
 src/wifi/model/wifi-mode.h       | 2 +-
 src/wifi/model/wifi-tx-vector.cc | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/wifi/model/wifi-mode.cc b/src/wifi/model/wifi-mode.cc
index 65c56d08d..fa78548db 100644
--- a/src/wifi/model/wifi-mode.cc
+++ b/src/wifi/model/wifi-mode.cc
@@ -136,7 +136,7 @@ WifiMode::GetConstellationSize (void) const
   return item->GetConstellationSizeCallback ();
 }
 
-std::string
+const std::string&
 WifiMode::GetUniqueName (void) const
 {
   //needed for ostream printing of the invalid mode
diff --git a/src/wifi/model/wifi-mode.h b/src/wifi/model/wifi-mode.h
index 7b294650b..1860843d5 100644
--- a/src/wifi/model/wifi-mode.h
+++ b/src/wifi/model/wifi-mode.h
@@ -127,7 +127,7 @@ public:
    * \returns a human-readable representation of this WifiMode
    * instance.
    */
-  std::string GetUniqueName (void) const;
+  const std::string& GetUniqueName (void) const;
   /**
    * \returns true if this mode is a mandatory mode, false
    *          otherwise.
diff --git a/src/wifi/model/wifi-tx-vector.cc b/src/wifi/model/wifi-tx-vector.cc
index ab2df79c4..969f0b55e 100644
--- a/src/wifi/model/wifi-tx-vector.cc
+++ b/src/wifi/model/wifi-tx-vector.cc
@@ -337,7 +337,7 @@ WifiTxVector::IsValid (void) const
     {
       return false;
     }
-  std::string modeName = m_mode.GetUniqueName ();
+  const std::string& modeName = m_mode.GetUniqueName ();
   if (m_channelWidth == 20)
     {
       if (m_nss != 3 && m_nss != 6)