diff --git a/RELEASE_NOTES b/RELEASE_NOTES index 8bd510c43..9eb49c57a 100644 --- a/RELEASE_NOTES +++ b/RELEASE_NOTES @@ -36,6 +36,7 @@ Bugs fixed - Bug 1582 - IPv6 raw socket return value is not like Linux socket - bug 1585 - Length field of A-MSDU subframe header endianness - Bug 1409 - Add an attribute "SystemId" to configure the ID for MPI +- Bug 1601 - RttEstimator doesn't set the m_currentEstimatedRtt to m_initialEstimatedRtt on creation - Bug 1612 - pyviz (visualizer) will not be installed - Bug 1623 - pybindgen rev809 is not able to build after Ubuntu 1210 diff --git a/doc/manual/source/attributes.rst b/doc/manual/source/attributes.rst index ddbfd0eac..9e2da8c74 100644 --- a/doc/manual/source/attributes.rst +++ b/doc/manual/source/attributes.rst @@ -492,6 +492,10 @@ follows::: // continue on with constructor. } +Beware that the object and all its derived classes must also implement a +``virtual TypeId GetInstanceTypeId (void) const;`` method. Otherwise the +``ObjectBase::ConstructSelf ()`` will not be able to read the attributes. + Extending attributes ******************** diff --git a/src/internet/model/rtt-estimator.cc b/src/internet/model/rtt-estimator.cc index d67012344..e2fa1dc88 100644 --- a/src/internet/model/rtt-estimator.cc +++ b/src/internet/model/rtt-estimator.cc @@ -134,6 +134,12 @@ RttEstimator::~RttEstimator () NS_LOG_FUNCTION (this); } +TypeId +RttEstimator::GetInstanceTypeId (void) const +{ + return GetTypeId (); +} + void RttEstimator::SentSeq (SequenceNumber32 seq, uint32_t size) { NS_LOG_FUNCTION (this << seq << size); @@ -254,6 +260,12 @@ RttMeanDeviation::RttMeanDeviation (const RttMeanDeviation& c) NS_LOG_FUNCTION (this); } +TypeId +RttMeanDeviation::GetInstanceTypeId (void) const +{ + return GetTypeId (); +} + void RttMeanDeviation::Measurement (Time m) { NS_LOG_FUNCTION (this << m); diff --git a/src/internet/model/rtt-estimator.h b/src/internet/model/rtt-estimator.h index 787f7e6f7..06dc72726 100644 --- a/src/internet/model/rtt-estimator.h +++ b/src/internet/model/rtt-estimator.h @@ -64,6 +64,8 @@ public: virtual ~RttEstimator(); + virtual TypeId GetInstanceTypeId (void) const; + /** * \brief Note that a particular sequence has been sent * \param seq the packet sequence number. @@ -167,6 +169,8 @@ public: RttMeanDeviation (const RttMeanDeviation&); + virtual TypeId GetInstanceTypeId (void) const; + /** * \brief Add a new measurement to the estimator. * \param measure the new RTT measure.