From cddb3bfe23e4f5b87dca08622d6104e08f81849b Mon Sep 17 00:00:00 2001 From: Mathieu Lacage Date: Tue, 10 Mar 2009 14:18:32 +0100 Subject: [PATCH] StaticMobilityModel -> ConstantPositionMobilityModel, StaticSpeedMobilityModel -> ConstantVelocityMobilityModel --- examples/third.cc | 2 +- examples/wifi-adhoc.cc | 2 +- examples/wifi-wired-bridging.cc | 2 +- samples/main-grid-topology.cc | 2 +- samples/main-propagation-loss.cc | 6 ++--- samples/main-random-topology.cc | 2 +- src/devices/wifi/propagation-loss-model.cc | 1 - src/devices/wifi/wifi-phy-test.cc | 12 +++++----- src/devices/wifi/wifi-test.cc | 4 ++-- src/helper/mobility-helper.cc | 2 +- src/helper/ns2-mobility-helper.cc | 12 +++++----- src/helper/ns2-mobility-helper.h | 4 ++-- ...cc => constant-position-mobility-model.cc} | 20 ++++++++--------- ...l.h => constant-position-mobility-model.h} | 6 ++--- ...cc => constant-velocity-mobility-model.cc} | 22 +++++++++---------- ...l.h => constant-velocity-mobility-model.h} | 6 ++--- src/mobility/mobility.h | 4 ++-- src/mobility/wscript | 8 +++---- 18 files changed, 58 insertions(+), 59 deletions(-) rename src/mobility/{static-mobility-model.cc => constant-position-mobility-model.cc} (64%) rename src/mobility/{static-mobility-model.h => constant-position-mobility-model.h} (91%) rename src/mobility/{static-speed-mobility-model.cc => constant-velocity-mobility-model.cc} (65%) rename src/mobility/{static-speed-mobility-model.h => constant-velocity-mobility-model.h} (92%) diff --git a/examples/third.cc b/examples/third.cc index 2888144d3..550ac78d6 100644 --- a/examples/third.cc +++ b/examples/third.cc @@ -120,7 +120,7 @@ main (int argc, char *argv[]) "Bounds", RectangleValue (Rectangle (-50, 50, -50, 50))); mobility.Install (wifiStaNodes); - mobility.SetMobilityModel ("ns3::StaticMobilityModel"); + mobility.SetMobilityModel ("ns3::ConstantPositionMobilityModel"); mobility.Install (wifiApNode); InternetStackHelper stack; diff --git a/examples/wifi-adhoc.cc b/examples/wifi-adhoc.cc index a5f7ff3c6..50e99073a 100644 --- a/examples/wifi-adhoc.cc +++ b/examples/wifi-adhoc.cc @@ -128,7 +128,7 @@ Experiment::Run (const WifiHelper &wifi, const YansWifiPhyHelper &wifiPhy, const positionAlloc->Add (Vector (0.0, 0.0, 0.0)); positionAlloc->Add (Vector (5.0, 0.0, 0.0)); mobility.SetPositionAllocator (positionAlloc); - mobility.SetMobilityModel ("ns3::StaticMobilityModel"); + mobility.SetMobilityModel ("ns3::ConstantPositionMobilityModel"); mobility.Install (c); diff --git a/examples/wifi-wired-bridging.cc b/examples/wifi-wired-bridging.cc index 7b11cf085..1994a086f 100644 --- a/examples/wifi-wired-bridging.cc +++ b/examples/wifi-wired-bridging.cc @@ -119,7 +119,7 @@ int main (int argc, char *argv[]) // setup the AP. - mobility.SetMobilityModel ("ns3::StaticMobilityModel"); + mobility.SetMobilityModel ("ns3::ConstantPositionMobilityModel"); mobility.Install (backboneNodes.Get (i)); wifi.SetMac ("ns3::NqapWifiMac", "Ssid", SsidValue (ssid), diff --git a/samples/main-grid-topology.cc b/samples/main-grid-topology.cc index e1c6ce6d2..7f35daf7f 100644 --- a/samples/main-grid-topology.cc +++ b/samples/main-grid-topology.cc @@ -32,7 +32,7 @@ int main (int argc, char *argv[]) // each object will be attached a static position. // i.e., once set by the "position allocator", the // position will never change. - mobility.SetMobilityModel ("ns3::StaticMobilityModel"); + mobility.SetMobilityModel ("ns3::ConstantPositionMobilityModel"); // finalize the setup by attaching to each object // in the input array a position and initializing diff --git a/samples/main-propagation-loss.cc b/samples/main-propagation-loss.cc index d0af2d71e..b16279004 100644 --- a/samples/main-propagation-loss.cc +++ b/samples/main-propagation-loss.cc @@ -18,7 +18,7 @@ * Author: Mathieu Lacage */ #include "ns3/propagation-loss-model.h" -#include "ns3/static-mobility-model.h" +#include "ns3/constant-position-mobility-model.h" #include "ns3/config.h" #include "ns3/string.h" @@ -27,8 +27,8 @@ using namespace ns3; static void PrintOne (double minTxpower, double maxTxpower, double stepTxpower, double min, double max, double step) { - Ptr a = CreateObject (); - Ptr b = CreateObject (); + Ptr a = CreateObject (); + Ptr b = CreateObject (); Ptr log = CreateObject (); Ptr model = log; diff --git a/samples/main-random-topology.cc b/samples/main-random-topology.cc index 899a3b1ed..4c7e7b512 100644 --- a/samples/main-random-topology.cc +++ b/samples/main-random-topology.cc @@ -29,7 +29,7 @@ int main (int argc, char *argv[]) "X", StringValue ("100.0"), "Y", StringValue ("100.0"), "Rho", StringValue ("Uniform:0:30")); - mobility.SetMobilityModel ("ns3::StaticMobilityModel"); + mobility.SetMobilityModel ("ns3::ConstantPositionMobilityModel"); mobility.Install (c); Config::Connect ("/NodeList/*/$ns3::MobilityModelNotifier/CourseChange", diff --git a/src/devices/wifi/propagation-loss-model.cc b/src/devices/wifi/propagation-loss-model.cc index 9205305d2..058e84b2d 100644 --- a/src/devices/wifi/propagation-loss-model.cc +++ b/src/devices/wifi/propagation-loss-model.cc @@ -22,7 +22,6 @@ #include "propagation-loss-model.h" #include "ns3/log.h" #include "ns3/mobility-model.h" -#include "ns3/static-mobility-model.h" #include "ns3/boolean.h" #include "ns3/double.h" #include diff --git a/src/devices/wifi/wifi-phy-test.cc b/src/devices/wifi/wifi-phy-test.cc index 029f4fe75..d1ee08880 100644 --- a/src/devices/wifi/wifi-phy-test.cc +++ b/src/devices/wifi/wifi-phy-test.cc @@ -7,7 +7,7 @@ #include "yans-error-rate-model.h" #include "ns3/ptr.h" #include "ns3/mobility-model.h" -#include "ns3/static-mobility-model.h" +#include "ns3/constant-position-mobility-model.h" #include "ns3/vector.h" #include "ns3/packet.h" #include "ns3/simulator.h" @@ -75,9 +75,9 @@ PsrExperiment::Run (struct PsrExperiment::Input input) m_output.received = 0; m_input = input; - Ptr posTx = CreateObject (); + Ptr posTx = CreateObject (); posTx->SetPosition (Vector (0.0, 0.0, 0.0)); - Ptr posRx = CreateObject (); + Ptr posRx = CreateObject (); posRx->SetPosition (Vector (m_input.distance, 0.0, 0.0)); Ptr channel = CreateObject (); @@ -207,11 +207,11 @@ CollisionExperiment::Run (struct CollisionExperiment::Input input) Ptr log = CreateObject (); channel->SetPropagationLossModel (log); - Ptr posTxA = CreateObject (); + Ptr posTxA = CreateObject (); posTxA->SetPosition (Vector (input.xA, 0.0, 0.0)); - Ptr posTxB = CreateObject (); + Ptr posTxB = CreateObject (); posTxB->SetPosition (Vector (input.xB, 0.0, 0.0)); - Ptr posRx = CreateObject (); + Ptr posRx = CreateObject (); posRx->SetPosition (Vector (0, 0.0, 0.0)); Ptr txA = CreateObject (); diff --git a/src/devices/wifi/wifi-test.cc b/src/devices/wifi/wifi-test.cc index 413141acd..045e7081b 100644 --- a/src/devices/wifi/wifi-test.cc +++ b/src/devices/wifi/wifi-test.cc @@ -9,7 +9,7 @@ #include "propagation-loss-model.h" #include "error-rate-model.h" #include "yans-error-rate-model.h" -#include "ns3/static-mobility-model.h" +#include "ns3/constant-position-mobility-model.h" #include "ns3/node.h" #include "ns3/simulator.h" #include "ns3/test.h" @@ -51,7 +51,7 @@ WifiTest::CreateOne (Vector pos, Ptr channel) Ptr dev = CreateObject (); Ptr mac = m_mac.Create (); - Ptr mobility = CreateObject (); + Ptr mobility = CreateObject (); Ptr phy = CreateObject (); Ptr error = CreateObject (); phy->SetErrorRateModel (error); diff --git a/src/helper/mobility-helper.cc b/src/helper/mobility-helper.cc index 34ad62e81..bca62db35 100644 --- a/src/helper/mobility-helper.cc +++ b/src/helper/mobility-helper.cc @@ -37,7 +37,7 @@ MobilityHelper::MobilityHelper () m_position = CreateObject ("X", RandomVariableValue (ConstantVariable (0.0)), "Y", RandomVariableValue (ConstantVariable (0.0))); - m_mobility.SetTypeId ("ns3::StaticMobilityModel"); + m_mobility.SetTypeId ("ns3::ConstantPositionMobilityModel"); } MobilityHelper::~MobilityHelper () {} diff --git a/src/helper/ns2-mobility-helper.cc b/src/helper/ns2-mobility-helper.cc index 8e20f1d79..67dfd2fe4 100644 --- a/src/helper/ns2-mobility-helper.cc +++ b/src/helper/ns2-mobility-helper.cc @@ -23,7 +23,7 @@ #include "ns3/simulator.h" #include "ns3/node-list.h" #include "ns3/node.h" -#include "ns3/static-speed-mobility-model.h" +#include "ns3/constant-velocity-mobility-model.h" #include "ns2-mobility-helper.h" NS_LOG_COMPONENT_DEFINE ("Ns2MobilityHelper"); @@ -37,7 +37,7 @@ Ns2MobilityHelper::Ns2MobilityHelper (std::string filename) -Ptr +Ptr Ns2MobilityHelper::GetMobilityModel (std::string idString, const ObjectStore &store) const { std::istringstream iss; @@ -49,10 +49,10 @@ Ns2MobilityHelper::GetMobilityModel (std::string idString, const ObjectStore &st { return 0; } - Ptr model = object->GetObject (); + Ptr model = object->GetObject (); if (model == 0) { - model = CreateObject (); + model = CreateObject (); object->AggregateObject (model); } return model; @@ -85,7 +85,7 @@ Ns2MobilityHelper::LayoutObjectStore (const ObjectStore &store) const { continue; } - Ptr model = GetMobilityModel (line.substr (startNodeId + 1, + Ptr model = GetMobilityModel (line.substr (startNodeId + 1, endNodeId - startNodeId), store); if (model == 0) @@ -130,7 +130,7 @@ Ns2MobilityHelper::LayoutObjectStore (const ObjectStore &store) const double ySpeed = ReadDouble (line.substr (xSpeedEnd + 1, ySpeedEnd - xSpeedEnd - 1)); double zSpeed = ReadDouble (line.substr (ySpeedEnd + 1, std::string::npos)); NS_LOG_DEBUG ("at=" << at << "xSpeed=" << xSpeed << ", ySpeed=" << ySpeed << ", zSpeed=" << zSpeed); - Simulator::Schedule (Seconds (at), &StaticSpeedMobilityModel::SetVelocity, model, + Simulator::Schedule (Seconds (at), &ConstantVelocityMobilityModel::SetVelocity, model, Vector (xSpeed, ySpeed, zSpeed)); } } diff --git a/src/helper/ns2-mobility-helper.h b/src/helper/ns2-mobility-helper.h index 795f16392..fea52c6b0 100644 --- a/src/helper/ns2-mobility-helper.h +++ b/src/helper/ns2-mobility-helper.h @@ -27,7 +27,7 @@ namespace ns3 { -class StaticSpeedMobilityModel; +class ConstantVelocityMobilityModel; /** * \brief a topology object which can read ns2's movement files @@ -71,7 +71,7 @@ private: virtual Ptr Get (uint32_t i) const = 0; }; void LayoutObjectStore (const ObjectStore &store) const; - Ptr GetMobilityModel (std::string idString, const ObjectStore &store) const; + Ptr GetMobilityModel (std::string idString, const ObjectStore &store) const; double ReadDouble (std::string valueString) const; std::string m_filename; }; diff --git a/src/mobility/static-mobility-model.cc b/src/mobility/constant-position-mobility-model.cc similarity index 64% rename from src/mobility/static-mobility-model.cc rename to src/mobility/constant-position-mobility-model.cc index 142cd379c..1e0526856 100644 --- a/src/mobility/static-mobility-model.cc +++ b/src/mobility/constant-position-mobility-model.cc @@ -17,40 +17,40 @@ * * Author: Mathieu Lacage */ -#include "static-mobility-model.h" +#include "constant-position-mobility-model.h" namespace ns3 { -NS_OBJECT_ENSURE_REGISTERED (StaticMobilityModel); +NS_OBJECT_ENSURE_REGISTERED (ConstantPositionMobilityModel); TypeId -StaticMobilityModel::GetTypeId (void) +ConstantPositionMobilityModel::GetTypeId (void) { - static TypeId tid = TypeId ("ns3::StaticMobilityModel") + static TypeId tid = TypeId ("ns3::ConstantPositionMobilityModel") .SetParent () - .AddConstructor () + .AddConstructor () ; return tid; } -StaticMobilityModel::StaticMobilityModel () +ConstantPositionMobilityModel::ConstantPositionMobilityModel () {} -StaticMobilityModel::~StaticMobilityModel () +ConstantPositionMobilityModel::~ConstantPositionMobilityModel () {} Vector -StaticMobilityModel::DoGetPosition (void) const +ConstantPositionMobilityModel::DoGetPosition (void) const { return m_position; } void -StaticMobilityModel::DoSetPosition (const Vector &position) +ConstantPositionMobilityModel::DoSetPosition (const Vector &position) { m_position = position; NotifyCourseChange (); } Vector -StaticMobilityModel::DoGetVelocity (void) const +ConstantPositionMobilityModel::DoGetVelocity (void) const { return Vector (0.0, 0.0, 0.0); } diff --git a/src/mobility/static-mobility-model.h b/src/mobility/constant-position-mobility-model.h similarity index 91% rename from src/mobility/static-mobility-model.h rename to src/mobility/constant-position-mobility-model.h index f7b936cc2..b16f22290 100644 --- a/src/mobility/static-mobility-model.h +++ b/src/mobility/constant-position-mobility-model.h @@ -30,15 +30,15 @@ namespace ns3 { * change once it has been set and until it is set again * explicitely to a new value. */ -class StaticMobilityModel : public MobilityModel +class ConstantPositionMobilityModel : public MobilityModel { public: static TypeId GetTypeId (void); /** * Create a position located at coordinates (0,0,0) */ - StaticMobilityModel (); - virtual ~StaticMobilityModel (); + ConstantPositionMobilityModel (); + virtual ~ConstantPositionMobilityModel (); private: virtual Vector DoGetPosition (void) const; diff --git a/src/mobility/static-speed-mobility-model.cc b/src/mobility/constant-velocity-mobility-model.cc similarity index 65% rename from src/mobility/static-speed-mobility-model.cc rename to src/mobility/constant-velocity-mobility-model.cc index 50e153328..224359b15 100644 --- a/src/mobility/static-speed-mobility-model.cc +++ b/src/mobility/constant-velocity-mobility-model.cc @@ -17,29 +17,29 @@ * * Author: Mathieu Lacage */ -#include "static-speed-mobility-model.h" +#include "constant-velocity-mobility-model.h" #include "ns3/simulator.h" namespace ns3 { -NS_OBJECT_ENSURE_REGISTERED (StaticSpeedMobilityModel); +NS_OBJECT_ENSURE_REGISTERED (ConstantVelocityMobilityModel); -TypeId StaticSpeedMobilityModel::GetTypeId (void) +TypeId ConstantVelocityMobilityModel::GetTypeId (void) { - static TypeId tid = TypeId ("ns3::StaticSpeedMobilityModel") + static TypeId tid = TypeId ("ns3::ConstantVelocityMobilityModel") .SetParent () - .AddConstructor (); + .AddConstructor (); return tid; } -StaticSpeedMobilityModel::StaticSpeedMobilityModel () +ConstantVelocityMobilityModel::ConstantVelocityMobilityModel () {} -StaticSpeedMobilityModel::~StaticSpeedMobilityModel () +ConstantVelocityMobilityModel::~ConstantVelocityMobilityModel () {} void -StaticSpeedMobilityModel::SetVelocity (const Vector &speed) +ConstantVelocityMobilityModel::SetVelocity (const Vector &speed) { m_helper.Update (); m_helper.SetVelocity (speed); @@ -49,19 +49,19 @@ StaticSpeedMobilityModel::SetVelocity (const Vector &speed) Vector -StaticSpeedMobilityModel::DoGetPosition (void) const +ConstantVelocityMobilityModel::DoGetPosition (void) const { m_helper.Update (); return m_helper.GetCurrentPosition (); } void -StaticSpeedMobilityModel::DoSetPosition (const Vector &position) +ConstantVelocityMobilityModel::DoSetPosition (const Vector &position) { m_helper.SetPosition (position); NotifyCourseChange (); } Vector -StaticSpeedMobilityModel::DoGetVelocity (void) const +ConstantVelocityMobilityModel::DoGetVelocity (void) const { return m_helper.GetVelocity (); } diff --git a/src/mobility/static-speed-mobility-model.h b/src/mobility/constant-velocity-mobility-model.h similarity index 92% rename from src/mobility/static-speed-mobility-model.h rename to src/mobility/constant-velocity-mobility-model.h index b222f1268..5ce8bc4b8 100644 --- a/src/mobility/static-speed-mobility-model.h +++ b/src/mobility/constant-velocity-mobility-model.h @@ -32,7 +32,7 @@ namespace ns3 { * change once it has been set and until it is set again * explicitely to a new value. */ -class StaticSpeedMobilityModel : public MobilityModel +class ConstantVelocityMobilityModel : public MobilityModel { public: static TypeId GetTypeId (void); @@ -40,8 +40,8 @@ public: * Create position located at coordinates (0,0,0) with * speed (0,0,0). */ - StaticSpeedMobilityModel (); - virtual ~StaticSpeedMobilityModel (); + ConstantVelocityMobilityModel (); + virtual ~ConstantVelocityMobilityModel (); /** * \param speed the new speed to set. diff --git a/src/mobility/mobility.h b/src/mobility/mobility.h index cca34b6e6..98e2f37e1 100644 --- a/src/mobility/mobility.h +++ b/src/mobility/mobility.h @@ -9,10 +9,10 @@ * listeners to the course changes of a mobility model * * The mobility models themselves are: - * - ns3::StaticMobilityModel: a model which maintains a constant position + * - ns3::ConstantPositionMobilityModel: a model which maintains a constant position * until it is changed by the user. * - * - ns3::StaticSpeedMobilityModel: a model which maintains a constant speed + * - ns3::ConstantVelocityMobilityModel: a model which maintains a constant speed * until it is changed by the user. * * - ns3::HierarchicalMobilityModel: a model which calculates the current diff --git a/src/mobility/wscript b/src/mobility/wscript index 0163e3639..30ce477a1 100644 --- a/src/mobility/wscript +++ b/src/mobility/wscript @@ -8,9 +8,9 @@ def build(bld): 'mobility-model.cc', 'position-allocator.cc', 'rectangle.cc', - 'static-mobility-model.cc', + 'constant-position-mobility-model.cc', 'static-speed-helper.cc', - 'static-speed-mobility-model.cc', + 'constant-velocity-mobility-model.cc', 'random-waypoint-mobility-model.cc', 'random-walk-2d-mobility-model.cc', 'random-direction-2d-mobility-model.cc', @@ -24,9 +24,9 @@ def build(bld): 'mobility-model.h', 'position-allocator.h', 'rectangle.h', - 'static-mobility-model.h', + 'constant-position-mobility-model.h', 'static-speed-helper.h', - 'static-speed-mobility-model.h', + 'constant-velocity-mobility-model.h', 'random-waypoint-mobility-model.h', 'random-walk-2d-mobility-model.h', 'random-direction-2d-mobility-model.h',