From cd271215db78e1d2a7feb5723b7fdf287365e6d1 Mon Sep 17 00:00:00 2001 From: Gabriel Ferreira Date: Sat, 18 Jun 2022 20:23:50 -0300 Subject: [PATCH] lte: skip redundant copy of 'sinr' in lte-mi-error-model.cc --- src/lte/model/lte-mi-error-model.cc | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/lte/model/lte-mi-error-model.cc b/src/lte/model/lte-mi-error-model.cc index 2c2f955db..50168ec22 100644 --- a/src/lte/model/lte-mi-error-model.cc +++ b/src/lte/model/lte-mi-error-model.cc @@ -338,11 +338,10 @@ LteMiErrorModel::Mib (const SpectrumValue& sinr, const std::vector& map, ui double MI; double MIsum = 0.0; - SpectrumValue sinrCopy = sinr; for (uint32_t i = 0; i < map.size (); i++) { - double sinrLin = sinrCopy[map.at (i)]; + double sinrLin = sinr[map.at (i)]; if (mcs <= MI_QPSK_MAX_ID) // QPSK { @@ -468,11 +467,10 @@ LteMiErrorModel::GetPcfichPdcchError (const SpectrumValue& sinr) NS_LOG_FUNCTION (sinr); double MI; double MIsum = 0.0; - SpectrumValue sinrCopy = sinr; - Values::iterator sinrIt = sinrCopy.ValuesBegin (); + Values::const_iterator sinrIt = sinr.ConstValuesBegin (); uint16_t rb = 0; - NS_ASSERT (sinrIt!=sinrCopy.ValuesEnd ()); - while (sinrIt!=sinrCopy.ValuesEnd ()) + NS_ASSERT (sinrIt!=sinr.ConstValuesEnd ()); + while (sinrIt!=sinr.ConstValuesEnd ()) { double sinrLin = *sinrIt; if (sinrLin > MI_map_qpsk_axis[MI_MAP_QPSK_SIZE-1])