From c4783e254bc4a4ff55ef26a1f59a8b25ff88478f Mon Sep 17 00:00:00 2001 From: F5 Date: Wed, 22 Nov 2023 16:12:05 +0800 Subject: [PATCH] flow-monitor: Fix clang-tidy warnings --- src/flow-monitor/model/flow-monitor.cc | 12 ++++++++---- src/flow-monitor/model/ipv4-flow-classifier.cc | 3 ++- src/flow-monitor/model/ipv6-flow-classifier.cc | 3 ++- 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/src/flow-monitor/model/flow-monitor.cc b/src/flow-monitor/model/flow-monitor.cc index 7e77c25f9..a948357b4 100644 --- a/src/flow-monitor/model/flow-monitor.cc +++ b/src/flow-monitor/model/flow-monitor.cc @@ -162,7 +162,8 @@ FlowMonitor::ReportFirstTx(Ptr probe, #ifdef NS3_MTP while (m_lock.exchange(true, std::memory_order_acquire)) - ; + { + }; #endif TrackedPacket& tracked = m_trackedPackets[std::make_pair(flowId, packetId)]; @@ -203,7 +204,8 @@ FlowMonitor::ReportForwarding(Ptr probe, #ifdef NS3_MTP while (m_lock.exchange(true, std::memory_order_acquire)) - ; + { + }; #endif std::pair key(flowId, packetId); @@ -244,7 +246,8 @@ FlowMonitor::ReportLastRx(Ptr probe, #ifdef NS3_MTP while (m_lock.exchange(true, std::memory_order_acquire)) - ; + { + }; #endif auto tracked = m_trackedPackets.find(std::make_pair(flowId, packetId)); @@ -326,7 +329,8 @@ FlowMonitor::ReportDrop(Ptr probe, #ifdef NS3_MTP while (m_lock.exchange(true, std::memory_order_acquire)) - ; + { + }; #endif probe->AddPacketDropStats(flowId, packetSize, reasonCode); diff --git a/src/flow-monitor/model/ipv4-flow-classifier.cc b/src/flow-monitor/model/ipv4-flow-classifier.cc index 858f3c12e..5374aed84 100644 --- a/src/flow-monitor/model/ipv4-flow-classifier.cc +++ b/src/flow-monitor/model/ipv4-flow-classifier.cc @@ -149,7 +149,8 @@ Ipv4FlowClassifier::Classify(const Ipv4Header& ipHeader, #ifdef NS3_MTP while (m_lock.exchange(true, std::memory_order_acquire)) - ; + { + }; #endif // try to insert the tuple, but check if it already exists diff --git a/src/flow-monitor/model/ipv6-flow-classifier.cc b/src/flow-monitor/model/ipv6-flow-classifier.cc index 9a51a757f..7800fc508 100644 --- a/src/flow-monitor/model/ipv6-flow-classifier.cc +++ b/src/flow-monitor/model/ipv6-flow-classifier.cc @@ -150,7 +150,8 @@ Ipv6FlowClassifier::Classify(const Ipv6Header& ipHeader, #ifdef NS3_MTP while (m_lock.exchange(true, std::memory_order_acquire)) - ; + { + }; #endif // try to insert the tuple, but check if it already exists