From c4261cd8153861e740fdb6e28af0fedfeb5468bd Mon Sep 17 00:00:00 2001 From: Gabriel Ferreira Date: Wed, 17 Apr 2024 23:04:50 +0200 Subject: [PATCH] build: (fixes #1065) Avoid lld issue by reverting -Os to -O2 builds on MacOS --- build-support/macros-and-definitions.cmake | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/build-support/macros-and-definitions.cmake b/build-support/macros-and-definitions.cmake index f974bbd2a..65b884a71 100644 --- a/build-support/macros-and-definitions.cmake +++ b/build-support/macros-and-definitions.cmake @@ -159,9 +159,13 @@ macro(process_options) STREQUAL "default" ) set(cmakeBuildType relwithdebinfo) - string(REPLACE "-O2" "-Os" CMAKE_CXX_FLAGS_RELWITHDEBINFO - "${CMAKE_CXX_FLAGS_RELWITHDEBINFO}" - ) + # Do not use optimized for size builds on MacOS See issue #1065: + # https://gitlab.com/nsnam/ns-3-dev/-/issues/1065 + if(NOT (DEFINED APPLE)) + string(REPLACE "-O2" "-Os" CMAKE_CXX_FLAGS_RELWITHDEBINFO + "${CMAKE_CXX_FLAGS_RELWITHDEBINFO}" + ) + endif() set(CMAKE_CXX_FLAGS_DEFAULT ${CMAKE_CXX_FLAGS_RELWITHDEBINFO}) add_definitions(-DNS3_BUILD_PROFILE_DEBUG) elseif(${cmakeBuildType} STREQUAL "release")