From a905bf35a7acfeda73515e0bdd9872eca1cba1a5 Mon Sep 17 00:00:00 2001
From: "Gustavo J. A. M. Carneiro" <gjc@inescporto.pt>
Date: Thu, 2 Aug 2007 14:56:04 +0100
Subject: [PATCH] Send PacketMetadataTest unit test output to Failure (), not
 std::cout.

---
 src/common/packet-metadata.cc | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/src/common/packet-metadata.cc b/src/common/packet-metadata.cc
index 1308b7d12..c62b7d8f5 100644
--- a/src/common/packet-metadata.cc
+++ b/src/common/packet-metadata.cc
@@ -1377,13 +1377,13 @@ PacketMetadataTest::Check (const char *file, int line, std::list<int> expected)
 {
   if (m_headerError)
     {
-      std::cout << "PacketMetadata header error. file=" << file 
+      Failure () << "PacketMetadata header error. file=" << file 
                 << ", line=" << line << std::endl;
       return false;
     }
   if (m_trailerError)
     {
-      std::cout << "PacketMetadata trailer error. file=" << file 
+      Failure () << "PacketMetadata trailer error. file=" << file 
                 << ", line=" << line << std::endl;
       return false;
     }
@@ -1403,20 +1403,20 @@ PacketMetadataTest::Check (const char *file, int line, std::list<int> expected)
     }
   return true;
  error:
-  std::cout << "PacketMetadata error. file="<< file 
+  Failure () << "PacketMetadata error. file="<< file 
             << ", line=" << line << ", got:\"";
   for (std::list<int>::iterator i = m_prints.begin (); 
        i != m_prints.end (); i++)
     {
-      std::cout << *i << ", ";
+      Failure () << *i << ", ";
     }
-  std::cout << "\", expected: \"";
+  Failure () << "\", expected: \"";
   for (std::list<int>::iterator j = expected.begin ();
        j != expected.end (); j++)
     {
-      std::cout << *j << ", ";
+      Failure () << *j << ", ";
     }
-  std::cout << "\"" << std::endl;
+  Failure () << "\"" << std::endl;
   return false;
 }
 
@@ -1436,7 +1436,7 @@ PacketMetadataTest::CheckHistory (Packet p, const char *file, int line, uint32_t
   va_end (ap);
 
   m_printer.PrintForward ();
-  p.Print (std::cerr, m_printer);
+  p.Print (Failure (), m_printer);
   bool ok = Check (file, line, expected);
   CleanupPrints ();
   if (!ok)
@@ -1445,7 +1445,7 @@ PacketMetadataTest::CheckHistory (Packet p, const char *file, int line, uint32_t
     }
 
   m_printer.PrintBackward ();
-  p.Print (std::cerr, m_printer);
+  p.Print (Failure (), m_printer);
   expected.reverse ();
   ok = Check (file, line, expected);
   CleanupPrints ();