diff --git a/CHANGES.md b/CHANGES.md index 410dd46ec..4bf296d9a 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -35,6 +35,7 @@ Changes from ns-3.39 to ns-3-dev ### Changed behavior * (core) `EmpiricalRandomVariable` CDF pairs can now be added in any order. +* (core) `EmpiricalRandomVariable` no longer requires that a CDF pair with a range value exactly equal to 1.0 be added (see issue #922). * (wifi) Upon ML setup, a non-AP MLD updates the IDs of the setup links to match the IDs used by the AP MLD. * (wifi) Attribute **TrackSignalsFromInactiveInterfaces** in SpectrumWifiPhy has been defaulted to be enabled. diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index 44e68b291..c5afe3870 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -39,6 +39,7 @@ requirements (Note: not all ns-3 features are available on all systems): ### Bugs fixed +- (core) #922 - `EmpiricalRandomVariable` no longer requires that a CDF pair with a range value exactly equal to 1.0 be added. - (lr-wpan) - !1591 - Removed unnecessary Bcst filter from MAC - (wifi) - Reset MU PPDU UID to prevent STA from receiving the TB PPDU sent by another STA - (wifi) - Fix max value for UL MCS field of User Info fields (depends on TF variant) diff --git a/src/core/model/random-variable-stream.cc b/src/core/model/random-variable-stream.cc index 078c26738..229b96829 100644 --- a/src/core/model/random-variable-stream.cc +++ b/src/core/model/random-variable-stream.cc @@ -1735,12 +1735,6 @@ EmpiricalRandomVariable::Validate() << lastCdfPair->first << ", Value: " << lastCdfPair->second); } - // Check if last CDF ends with 1.0 - if (m_empCdf.rbegin()->first != 1.0) - { - NS_FATAL_ERROR("CDF does not cover the whole distribution"); - } - m_validated = true; }