Fix clang-tidy performance-unnecessary-copy-initialization warnings

Detected by clang-tidy-19
2024-10-30 20:28:51 +00:00
parent 28895f59d5
commit 7c6706acaa
10 changed files with 14 additions and 14 deletions
--- a/src/stats/model/sqlite-data-output.cc
+++ b/src/stats/model/sqlite-data-output.cc
@@ -107,7 +107,7 @@ SqliteDataOutput::Output(DataCollector& dc)

    for (auto i = dc.MetadataBegin(); i != dc.MetadataEnd(); i++)
    {
-        std::pair<std::string, std::string> blob = (*i);
+        const auto& blob = (*i);
        SQLiteOutput::SpinReset(stmt);
        m_sqliteOut->Bind(stmt, 1, run);
        m_sqliteOut->Bind(stmt, 2, blob.first);