From 685c075a9d4e84f7114531ae7741f409db5ec861 Mon Sep 17 00:00:00 2001 From: Shashwat Patni Date: Thu, 7 Aug 2025 22:23:55 +0530 Subject: [PATCH] internet: fix valgrind error in globalrouting caused by 3ff4a45 --- src/internet/model/ipv4-global-routing.cc | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/internet/model/ipv4-global-routing.cc b/src/internet/model/ipv4-global-routing.cc index 6c35247a9..b591194ac 100644 --- a/src/internet/model/ipv4-global-routing.cc +++ b/src/internet/model/ipv4-global-routing.cc @@ -76,6 +76,7 @@ Ipv4GlobalRouting::AddHostRouteTo(Ipv4Address dest, Ipv4Address nextHop, uint32_ if (*routePointer == *route) { NS_LOG_LOGIC("Route already exists"); + delete route; return; } } @@ -93,6 +94,7 @@ Ipv4GlobalRouting::AddHostRouteTo(Ipv4Address dest, uint32_t interface) if (*routePointer == *route) { NS_LOG_LOGIC("Route already exists"); + delete route; return; } } @@ -113,6 +115,7 @@ Ipv4GlobalRouting::AddNetworkRouteTo(Ipv4Address network, if (*routePointer == *route) { NS_LOG_LOGIC("Route already exists"); + delete route; return; } } @@ -130,6 +133,7 @@ Ipv4GlobalRouting::AddNetworkRouteTo(Ipv4Address network, Ipv4Mask networkMask, if (*routePointer == *route) { NS_LOG_LOGIC("Route already exists"); + delete route; return; } } @@ -150,6 +154,7 @@ Ipv4GlobalRouting::AddASExternalRouteTo(Ipv4Address network, if (*routePointer == *route) { NS_LOG_LOGIC("Route already exists"); + delete route; return; } }