From 5e7e0d7b2a6e35ffd57504a3794fdee30a03be14 Mon Sep 17 00:00:00 2001
From: Tom Henderson <tomh@tomh.org>
Date: Mon, 3 Sep 2007 23:32:23 -0700
Subject: [PATCH] Fold the two patches for bu6 69 together, building on the bug
 65 patch

---
 src/internet-node/ipv4-end-point.cc |  7 ++++
 src/internet-node/ipv4-end-point.h  |  1 +
 src/internet-node/udp-socket.cc     | 65 +++++++++++++++++++++++++----
 src/internet-node/udp-socket.h      |  1 +
 src/node/ipv4.cc                    |  5 +++
 src/node/socket.h                   |  1 +
 6 files changed, 71 insertions(+), 9 deletions(-)

diff --git a/src/internet-node/ipv4-end-point.cc b/src/internet-node/ipv4-end-point.cc
index 69faf523e..42cb45e37 100644
--- a/src/internet-node/ipv4-end-point.cc
+++ b/src/internet-node/ipv4-end-point.cc
@@ -42,6 +42,13 @@ Ipv4EndPoint::GetLocalAddress (void)
 {
   return m_localAddr;
 }
+
+void 
+Ipv4EndPoint::SetLocalAddress (Ipv4Address address)
+{
+  m_localAddr = address;
+}
+
 uint16_t 
 Ipv4EndPoint::GetLocalPort (void)
 {
diff --git a/src/internet-node/ipv4-end-point.h b/src/internet-node/ipv4-end-point.h
index f606aa63b..dfd0e6c57 100644
--- a/src/internet-node/ipv4-end-point.h
+++ b/src/internet-node/ipv4-end-point.h
@@ -37,6 +37,7 @@ public:
   ~Ipv4EndPoint ();
 
   Ipv4Address GetLocalAddress (void);
+  void SetLocalAddress (Ipv4Address address);
   uint16_t GetLocalPort (void);
   Ipv4Address GetPeerAddress (void);
   uint16_t GetPeerPort (void);
diff --git a/src/internet-node/udp-socket.cc b/src/internet-node/udp-socket.cc
index a2bde3224..a9b063a2c 100644
--- a/src/internet-node/udp-socket.cc
+++ b/src/internet-node/udp-socket.cc
@@ -20,6 +20,8 @@
  */
 #include "ns3/node.h"
 #include "ns3/inet-socket-address.h"
+#include "ns3/ipv4-route.h"
+#include "ns3/ipv4.h"
 #include "udp-socket.h"
 #include "udp-l4-protocol.h"
 #include "ipv4-end-point.h"
@@ -147,13 +149,25 @@ UdpSocket::Close(void)
 int
 UdpSocket::Connect(const Address & address)
 {
+  Ipv4Route routeToDest;
   InetSocketAddress transport = InetSocketAddress::ConvertFrom (address);
   m_defaultAddress = transport.GetIpv4 ();
   m_defaultPort = transport.GetPort ();
+  if (m_defaultAddress.IsBroadcast () )
+    {
+      NS_ASSERT_MSG(false, "UdpSocket::Connect, can't connect to broadcast");
+    }
   NotifyConnectionSucceeded ();
   m_connected = true;
+  if (GetIpv4RouteToDestination (m_node, routeToDest, m_defaultAddress) )
+    {
+      uint32_t localIfIndex = routeToDest.GetInterface ();
+      Ptr<Ipv4> ipv4 = m_node->QueryInterface<Ipv4> (Ipv4::iid);
+      m_endPoint->SetLocalAddress (ipv4->GetAddress(localIfIndex) );
+    }
   return 0;
 }
+
 int 
 UdpSocket::Send (const Packet &p)
 {
@@ -162,8 +176,33 @@ UdpSocket::Send (const Packet &p)
       m_errno = ERROR_NOTCONN;
       return -1;
     }
-  return DoSendTo (p, m_defaultAddress, m_defaultPort);
+  return DoSend (p);
 }
+
+int 
+UdpSocket::DoSend (const Packet &p)
+{
+  if (m_endPoint == 0)
+    {
+      if (Bind () == -1)
+       {
+          NS_ASSERT (m_endPoint == 0);
+         return -1;
+       }
+      NS_ASSERT (m_endPoint != 0);
+    }
+  if (m_shutdownSend)
+    {
+      m_errno = ERROR_SHUTDOWN;
+      return -1;
+    } 
+  m_udp->Send (p, m_endPoint->GetLocalAddress (), m_defaultAddress,
+                  m_endPoint->GetLocalPort (), m_defaultPort);
+  NotifyDataSent (p.GetSize ());
+  return 0;
+}
+
+
 int
 UdpSocket::DoSendTo (const Packet &p, const Address &address)
 {
@@ -173,7 +212,7 @@ UdpSocket::DoSendTo (const Packet &p, const Address &address)
   return DoSendTo (p, ipv4, port);
 }
 int
-UdpSocket::DoSendTo (const Packet &p, Ipv4Address ipv4, uint16_t port)
+UdpSocket::DoSendTo (const Packet &p, Ipv4Address dest, uint16_t port)
 {
   if (m_endPoint == 0)
     {
@@ -189,19 +228,27 @@ UdpSocket::DoSendTo (const Packet &p, Ipv4Address ipv4, uint16_t port)
       m_errno = ERROR_SHUTDOWN;
       return -1;
     }
-  m_udp->Send (p, m_endPoint->GetLocalAddress (), ipv4,
+  Ipv4Route routeToDest;
+  if (GetIpv4RouteToDestination (m_node, routeToDest, dest) )
+    {
+      uint32_t localIfIndex = routeToDest.GetInterface ();
+      Ptr<Ipv4> ipv4 = m_node->QueryInterface<Ipv4> (Ipv4::iid);
+      m_udp->Send (p, ipv4->GetAddress (localIfIndex), dest,
 		   m_endPoint->GetLocalPort (), port);
-  NotifyDataSent (p.GetSize ());
+      NotifyDataSent (p.GetSize ());
+      return 0;
+    }
+  else
+   {
+      m_errno = ERROR_NOROUTETOHOST;
+      return -1;
+   }
   return 0;
 }
+
 int 
 UdpSocket::SendTo(const Address &address, const Packet &p)
 {
-  if (m_connected)
-    {
-      m_errno = ERROR_ISCONN;
-      return -1;
-    }
   InetSocketAddress transport = InetSocketAddress::ConvertFrom (address);
   Ipv4Address ipv4 = transport.GetIpv4 ();
   uint16_t port = transport.GetPort ();
diff --git a/src/internet-node/udp-socket.h b/src/internet-node/udp-socket.h
index b3674f7ef..332e679d7 100644
--- a/src/internet-node/udp-socket.h
+++ b/src/internet-node/udp-socket.h
@@ -62,6 +62,7 @@ private:
   int FinishBind (void);
   void ForwardUp (const Packet &p, Ipv4Address ipv4, uint16_t port);
   void Destroy (void);
+  int DoSend (const Packet &p);
   int DoSendTo (const Packet &p, const Address &daddr);
   int DoSendTo (const Packet &p, Ipv4Address daddr, uint16_t dport);
 
diff --git a/src/node/ipv4.cc b/src/node/ipv4.cc
index 9578d4c8a..d7c83d42a 100644
--- a/src/node/ipv4.cc
+++ b/src/node/ipv4.cc
@@ -74,6 +74,11 @@ GetIpv4RouteToDestination (Ptr<Node> node, Ipv4Route& route,
           route = tempRoute;
           return true;
         }
+      else if ( tempRoute.IsDefault () )
+        {
+          route = tempRoute;
+          return true;
+        }
     }
   return false;
 }
diff --git a/src/node/socket.h b/src/node/socket.h
index c717ec0a5..fb62fdca3 100644
--- a/src/node/socket.h
+++ b/src/node/socket.h
@@ -58,6 +58,7 @@ public:
     ERROR_AFNOSUPPORT,
     ERROR_INVAL,
     ERROR_BADF,
+    ERROR_NOROUTETOHOST,
     SOCKET_ERRNO_LAST
   };