From 541d86254930995104d1360acfdacee2c23aa91b Mon Sep 17 00:00:00 2001
From: Amir Ashtari Gargari <aashtari@cttc.es>
Date: Mon, 11 Nov 2024 19:24:37 +0000
Subject: [PATCH] antenna: Add methods to get down tilt and bearing angles from
 UniformPlanarArray

---
 src/antenna/model/uniform-planar-array.cc | 34 ++++++++++++++++-------
 src/antenna/model/uniform-planar-array.h  | 12 ++++++++
 2 files changed, 36 insertions(+), 10 deletions(-)

diff --git a/src/antenna/model/uniform-planar-array.cc b/src/antenna/model/uniform-planar-array.cc
index 3b04e2bd6..68f6da395 100644
--- a/src/antenna/model/uniform-planar-array.cc
+++ b/src/antenna/model/uniform-planar-array.cc
@@ -60,16 +60,18 @@ UniformPlanarArray::GetTypeId()
                           MakeUintegerAccessor(&UniformPlanarArray::SetNumRows,
                                                &UniformPlanarArray::GetNumRows),
                           MakeUintegerChecker<uint32_t>(1))
-            .AddAttribute("BearingAngle",
-                          "The bearing angle in radians",
-                          DoubleValue(0.0),
-                          MakeDoubleAccessor(&UniformPlanarArray::SetAlpha),
-                          MakeDoubleChecker<double>(-M_PI, M_PI))
-            .AddAttribute("DowntiltAngle",
-                          "The downtilt angle in radians",
-                          DoubleValue(0.0),
-                          MakeDoubleAccessor(&UniformPlanarArray::SetBeta),
-                          MakeDoubleChecker<double>(-M_PI, M_PI))
+            .AddAttribute(
+                "BearingAngle",
+                "The bearing angle in radians",
+                DoubleValue(0.0),
+                MakeDoubleAccessor(&UniformPlanarArray::SetAlpha, &UniformPlanarArray::GetAlpha),
+                MakeDoubleChecker<double>(-M_PI, M_PI))
+            .AddAttribute(
+                "DowntiltAngle",
+                "The downtilt angle in radians",
+                DoubleValue(0.0),
+                MakeDoubleAccessor(&UniformPlanarArray::SetBeta, &UniformPlanarArray::GetBeta),
+                MakeDoubleChecker<double>(-M_PI, M_PI))
             .AddAttribute("PolSlantAngle",
                           "The polarization slant angle in radians",
                           DoubleValue(0.0),
@@ -380,6 +382,18 @@ UniformPlanarArray::SetDualPol(bool isDualPol)
     }
 }
 
+double
+UniformPlanarArray::GetAlpha() const
+{
+    return m_alpha;
+}
+
+double
+UniformPlanarArray::GetBeta() const
+{
+    return m_beta;
+}
+
 double
 UniformPlanarArray::GetPolSlant() const
 {
diff --git a/src/antenna/model/uniform-planar-array.h b/src/antenna/model/uniform-planar-array.h
index 59058e40e..82ffd3e7a 100644
--- a/src/antenna/model/uniform-planar-array.h
+++ b/src/antenna/model/uniform-planar-array.h
@@ -79,6 +79,18 @@ class UniformPlanarArray : public PhasedArrayModel
      */
     bool IsDualPol() const override;
 
+    /**
+     *  Returns bearing angle of first polarization
+     *  @return bearing angle in radians
+     */
+    double GetAlpha() const;
+
+    /**
+     *  Returns downtilt angle of first polarization
+     *  @return downtilt angle in radians
+     */
+    double GetBeta() const;
+
     /**
      *  Returns polarization angle of first polarization
      *  @return polarization angle in radians