From 4706ec48a91b356e98f0359b6f507bb150322c27 Mon Sep 17 00:00:00 2001 From: Marco Miozzo Date: Fri, 29 Jun 2012 11:51:22 +0200 Subject: [PATCH] Update code after internal review --- src/lte/model/ff-mac-common.cc | 8 -------- src/lte/model/ff-mac-common.h | 11 ++--------- src/lte/model/lte-enb-rrc.cc | 7 ------- src/lte/model/lte-enb-rrc.h | 1 - 4 files changed, 2 insertions(+), 25 deletions(-) diff --git a/src/lte/model/ff-mac-common.cc b/src/lte/model/ff-mac-common.cc index fb961cf82..c4967dac4 100644 --- a/src/lte/model/ff-mac-common.cc +++ b/src/lte/model/ff-mac-common.cc @@ -22,19 +22,11 @@ namespace ns3 { -VendorSpecificValue::VendorSpecificValue () -{ - -} VendorSpecificValue::~VendorSpecificValue () { } -// VendorSpecificValue::VendorSpecificValue (const VendorSpecificValue& p) -// { -// // remember to copy new parameters??? -// } } // namespace ns3 diff --git a/src/lte/model/ff-mac-common.h b/src/lte/model/ff-mac-common.h index f70898071..556f85849 100644 --- a/src/lte/model/ff-mac-common.h +++ b/src/lte/model/ff-mac-common.h @@ -149,19 +149,12 @@ struct UlDciListElement_s }; /** -* \brief Template class for storing the values of vendor specific parameters +* \brief Base class for storing the values of vendor specific parameters */ struct VendorSpecificValue : public SimpleRefCount { - VendorSpecificValue (); - virtual ~VendorSpecificValue (); - - /** - * copy constructor - */ - // do we need it? it seems that it works without it -// VendorSpecificValue (const VendorSpecificValue& p); // do we need it? + }; /** diff --git a/src/lte/model/lte-enb-rrc.cc b/src/lte/model/lte-enb-rrc.cc index dc41ccd29..0ed7a2e64 100644 --- a/src/lte/model/lte-enb-rrc.cc +++ b/src/lte/model/lte-enb-rrc.cc @@ -148,13 +148,6 @@ UeInfo::UeInfo (uint64_t imsi, uint16_t srsConfIndex) m_transmissionMode = 0; } -UeInfo::UeInfo (uint64_t imsi, uint16_t srsConfIndex, uint8_t txMode) -{ - m_imsi = imsi; - m_srsConfigurationIndex = srsConfIndex; - m_transmissionMode = txMode; -} - UeInfo::~UeInfo (void) diff --git a/src/lte/model/lte-enb-rrc.h b/src/lte/model/lte-enb-rrc.h index 15f95d8af..27e3f0bf6 100644 --- a/src/lte/model/lte-enb-rrc.h +++ b/src/lte/model/lte-enb-rrc.h @@ -78,7 +78,6 @@ public: UeInfo (void); UeInfo (uint64_t imsi); UeInfo (uint64_t imsi, uint16_t srsConfIndex); - UeInfo (uint64_t imsi, uint16_t srsConfIndex, uint8_t txMode); virtual ~UeInfo (void); static TypeId GetTypeId (void);