From 3d9d4ce7be89df74ed297196fa07a31f52dfb803 Mon Sep 17 00:00:00 2001 From: Mathieu Lacage Date: Tue, 31 Jul 2007 10:47:29 +0200 Subject: [PATCH] I wonder what the point of that code was: why should you test for zero _after_ using the pointer ? It needs to be tested _before_. --- src/internet-node/udp-socket.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/internet-node/udp-socket.cc b/src/internet-node/udp-socket.cc index bc83c942c..bdbc08887 100644 --- a/src/internet-node/udp-socket.cc +++ b/src/internet-node/udp-socket.cc @@ -73,12 +73,12 @@ UdpSocket::Destroy (void) int UdpSocket::FinishBind (void) { - m_endPoint->SetRxCallback (MakeCallback (&UdpSocket::ForwardUp, this)); - m_endPoint->SetDestroyCallback (MakeCallback (&UdpSocket::Destroy, this)); if (m_endPoint == 0) { return -1; } + m_endPoint->SetRxCallback (MakeCallback (&UdpSocket::ForwardUp, this)); + m_endPoint->SetDestroyCallback (MakeCallback (&UdpSocket::Destroy, this)); return 0; }