From 3898752f67df65fabfb672e70d01ce5e3028d818 Mon Sep 17 00:00:00 2001 From: "Gustavo J. A. M. Carneiro" Date: Fri, 28 Sep 2007 17:13:20 +0100 Subject: [PATCH] Fix infinite loop in CommandLine::Parse when trying to ignore a badly formed parameter. --- src/core/command-line.cc | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/core/command-line.cc b/src/core/command-line.cc index 481c925b4..d66ce53da 100644 --- a/src/core/command-line.cc +++ b/src/core/command-line.cc @@ -85,9 +85,7 @@ CommandLine::PrintHelp (void) void CommandLine::Parse (int argc, char *argv[]) { - argc--; - argv++; - while (argc > 0) + for (argc--, argv++; argc > 0; argc--, argv++) { // remove "--" or "-" heading. std::string param = *argv; @@ -142,8 +140,6 @@ CommandLine::Parse (int argc, char *argv[]) continue; } } - argc--; - argv++; } }