From 324f5bd48cfb7a3fb67c0dc94bdb6c68b4e4668a Mon Sep 17 00:00:00 2001 From: Tommaso Pecorella Date: Sun, 28 Sep 2025 11:32:33 +0200 Subject: [PATCH] internet: fix Valgrind issue in 5d4fc177ab149a6e32b98945a05d219e0b92dc59 --- src/internet/model/arp-cache.cc | 6 +++++- src/internet/model/ndisc-cache.cc | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/src/internet/model/arp-cache.cc b/src/internet/model/arp-cache.cc index f323ffc5a..dacf53cfa 100644 --- a/src/internet/model/arp-cache.cc +++ b/src/internet/model/arp-cache.cc @@ -88,7 +88,11 @@ void ArpCache::DoDispose() { NS_LOG_FUNCTION(this); - Flush(); + for (auto& iter : m_arpCache) + { + delete iter.second; /* delete the pointer ArpCache::Entry */ + } + m_arpCache.clear(); m_device = nullptr; m_interface = nullptr; if (!m_waitReplyTimer.IsPending()) diff --git a/src/internet/model/ndisc-cache.cc b/src/internet/model/ndisc-cache.cc index 9ffa1b07e..6c7d021bf 100644 --- a/src/internet/model/ndisc-cache.cc +++ b/src/internet/model/ndisc-cache.cc @@ -53,7 +53,11 @@ void NdiscCache::DoDispose() { NS_LOG_FUNCTION(this); - Flush(); + for (auto& iter : m_ndCache) + { + delete iter.second; /* delete the pointer NdiscCache::Entry */ + } + m_ndCache.clear(); m_device = nullptr; m_interface = nullptr; m_icmpv6 = nullptr;