From 0f243283a039fcaddbbf1750d0ec0c002bd2d8de Mon Sep 17 00:00:00 2001
From: F5 <i@f5soft.site>
Date: Wed, 22 Nov 2023 16:12:35 +0800
Subject: [PATCH] network: Fix clang-tidy warnings

---
 src/network/model/byte-tag-list.cc   | 8 ++++----
 src/network/model/packet-metadata.cc | 6 ++++--
 2 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/src/network/model/byte-tag-list.cc b/src/network/model/byte-tag-list.cc
index 149db5911..908ac5254 100644
--- a/src/network/model/byte-tag-list.cc
+++ b/src/network/model/byte-tag-list.cc
@@ -415,8 +415,8 @@ ByteTagListData*
 ByteTagList::Allocate(uint32_t size)
 {
     NS_LOG_FUNCTION(this << size);
-    uint8_t* buffer = new uint8_t[size + sizeof(ByteTagListData) - 4];
-    ByteTagListData* data = (ByteTagListData*)buffer;
+    auto* buffer = new uint8_t[size + sizeof(ByteTagListData) - 4];
+    auto* data = (ByteTagListData*)buffer;
     data->count = 1;
     data->size = size;
     data->dirty = 0;
@@ -427,7 +427,7 @@ void
 ByteTagList::Deallocate(ByteTagListData* data)
 {
     NS_LOG_FUNCTION(this << data);
-    if (data == 0)
+    if (data == nullptr)
     {
         return;
     }
@@ -436,7 +436,7 @@ ByteTagList::Deallocate(ByteTagListData* data)
 #ifdef NS3_MTP
         std::atomic_thread_fence(std::memory_order_acquire);
 #endif
-        uint8_t* buffer = (uint8_t*)data;
+        auto* buffer = (uint8_t*)data;
         delete[] buffer;
     }
 }
diff --git a/src/network/model/packet-metadata.cc b/src/network/model/packet-metadata.cc
index de41f4bd3..7ce4e6b37 100644
--- a/src/network/model/packet-metadata.cc
+++ b/src/network/model/packet-metadata.cc
@@ -576,7 +576,8 @@ PacketMetadata::Create(uint32_t size)
     }
 #ifdef NS3_MTP
     while (m_freeListUsing.exchange(true, std::memory_order_acquire))
-        ;
+    {
+    };
 #endif
     while (!m_freeList.empty())
     {
@@ -615,7 +616,8 @@ PacketMetadata::Recycle(PacketMetadata::Data* data)
     }
 #ifdef NS3_MTP
     while (m_freeListUsing.exchange(true, std::memory_order_acquire))
-        ;
+    {
+    };
 #endif
     NS_LOG_LOGIC("recycle size=" << data->m_size << ", list=" << m_freeList.size());
     NS_ASSERT(data->m_count == 0);