diff --git a/RELEASE_NOTES b/RELEASE_NOTES index 38d6edc4b..ae3e8ee61 100644 --- a/RELEASE_NOTES +++ b/RELEASE_NOTES @@ -33,6 +33,7 @@ Bugs fixed - Bug 1689 - IPv6 shouldn't add a default gateway without checking the Router lifetime - Bug 1700 - Ipv6RawSocket does not honor the bound address when sending packets - Bug 1701 - Ipv6StaticRouting: the source address should match the destination scope +- Bug 1703 - Nodes don't react to a DAD Known issues ------------ diff --git a/src/internet/model/icmpv6-l4-protocol.cc b/src/internet/model/icmpv6-l4-protocol.cc index 1700da653..669db6f1a 100644 --- a/src/internet/model/icmpv6-l4-protocol.cc +++ b/src/internet/model/icmpv6-l4-protocol.cc @@ -595,18 +595,16 @@ void Icmpv6L4Protocol::HandleNA (Ptr packet, Ipv6Address const &src, Ipv if (!entry) { - /* ouch!! we are victim of a DAD */ + /* ouch!! we might be victim of a DAD */ - /* Logically dead code (DEADCODE) - * b/c loop test compares default Ipv6InterfaceAddress to target - Ipv6InterfaceAddress ifaddr; bool found = false; uint32_t i = 0; - uint32_t nb = 0; + uint32_t nb = interface->GetNAddresses (); for (i = 0; i < nb; i++) { + ifaddr = interface->GetAddress (i); if (ifaddr.GetAddress () == target) { found = true; @@ -621,7 +619,7 @@ void Icmpv6L4Protocol::HandleNA (Ptr packet, Ipv6Address const &src, Ipv interface->SetState (ifaddr.GetAddress (), Ipv6InterfaceAddress::INVALID); } } - */ + /* we have not initiated any communication with the target so... discard the NA */ return; }